PRs for 4.4 are waiting for reviews - Printable Version +- CodeIgniter Forums (https://forum.codeigniter.com) +-- Forum: CodeIgniter 4 (https://forum.codeigniter.com/forumdisplay.php?fid=28) +--- Forum: CodeIgniter 4 Development (https://forum.codeigniter.com/forumdisplay.php?fid=27) +--- Thread: PRs for 4.4 are waiting for reviews (/showthread.php?tid=87335) Pages:
1
2
|
PRs for 4.4 are waiting for reviews - kenjis - 04-07-2023 If you are interested, please review: https://github.com/codeigniter4/CodeIgniter4/pulls?q=is%3Apr+is%3Aopen+label%3A4.4+sort%3Aupdated-desc RE: PRs for 4.4 are waiting for reviews - kenjis - 08-15-2023 v4.4.0 is around the corner. See https://github.com/codeigniter4/CodeIgniter4/issues/7812 Testing and reviews are welcome, and your contributions make it release sooner. RE: PRs for 4.4 are waiting for reviews - nc03061981 - 08-16-2023 Thanks CI Teams RE: PRs for 4.4 are waiting for reviews - kenjis - 08-16-2023 Testing 4.4 branch is also welcome! https://github.com/codeigniter4/CodeIgniter4/tree/4.4 RE: PRs for 4.4 are waiting for reviews - InsiteFX - 08-16-2023 Thank you CI Development Team. RE: PRs for 4.4 are waiting for reviews - ozornick - 08-17-2023 @kenjis is it possible to test the branch by installing it as a dependency? In vendor/ path RE: PRs for 4.4 are waiting for reviews - kenjis - 08-17-2023 Yes. If you use appstarter, run the following command: Code: $ php builds development The above command changes composer.json: Code: "require": { Change the version to 4.4 branch: Code: "require": { Run composer update: Code: $ composer update Update project files. See https://github.com/codeigniter4/CodeIgniter4/blob/4.4/user_guide_src/source/installation/upgrade_440.rst#mandatory-file-changes Code: $ cp vendor/codeigniter4/codeigniter4/public/index.php public/index.php Remove Router settings in Config/Routes.php: Code: --- a/app/Config/Routes.php RE: PRs for 4.4 are waiting for reviews - ozornick - 08-18-2023 @kenjis my test project is working. 1. Except for the parameters Entity::injectRawData() the new method is BC. 2. Why is there a difference in the class Config\App::class and \Config\App::class? PHP Code: // before working, in 4.4 return null RE: PRs for 4.4 are waiting for reviews - kenjis - 08-18-2023 @ozornick Oh, thank you for checking! 1. Why BC? What will be broken? It just adds a new method. 2. Oh, because your code was wrong. "Config\App::class" means "\Some\Where\Config\App::class" if the file has "namespace Some\Where;". And even if it does not exist, v4.3.x looks for "App" (short classname) in "\Config" (because of preferApp). But in 4.4, the framework looks for "\Some\Where\Config\App::class" because you specify class with the namespace, See https://github.com/codeigniter4/CodeIgniter4/blob/4.4/user_guide_src/source/installation/upgrade_440.rst#when-passing-fully-qualified-classnames-to-factories RE: PRs for 4.4 are waiting for reviews - kenjis - 08-18-2023 The user guide explanation is not a bit accurate. I sent a PR to improve: https://github.com/codeigniter4/CodeIgniter4/pull/7840/files |