QuickAuth Authentication Library Version 1.0.0 |
[eluser]Adam Griffiths[/eluser]
You definitely need to sort your indenting out. I noticed a few times you hadn't indented your code, this makes it harder to read. Indenting is good for the soul!! I think you need to read the PHP Style Guide - this will help you format your code properly. Is it really necessary to have an encrypt() function when all it does is return the sha1? I can understand if it was salted somehow, but it isn't. I also noticed you used the Active Record pattern, just a note that straight queries are faster, which may be better for your library as you mention it being quick in the name. Also you have a very primitive security features when checking the username and password of the user upon login, have you looked at the form validation library? This would provide a more secure and robust method of validation the forms. It's good though, well done. Thanks, Adam |
Messages In This Thread |
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 05:26 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 05:41 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 05:43 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 05:52 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 06:01 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 06:02 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 06:06 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 06:14 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-29-2009, 05:04 PM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 11-02-2009, 06:01 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-16-2010, 12:47 AM
|