[Deprecated] DMZ 1.5.3 (DataMapper OverZealous Edition)

[eluser]cberk[/eluser]
This could definitely be my error, rather than a bug, but I'm having some trouble with the _count_related function in DMZ.

Here's what I'm trying to do: I'm creating two new objects, one after the other. The first object is a required relationship for the second object. I thought that instead of checking both $object->save() functions for success/failure, I would take a shortcut and just use the first object in the second object's save() function without checking to make sure it exists first. But when the first object fails to save, the second object is still passing validation and saving to the database, without the required relationship. Here's a truncated version of my code:

Code:

// Record has_one Citation (required)

$citation = new Citation();
$citation->ref = 'some string';
$citation->save();

$record = new Record();
... // Record fields
$record->save($citation); // Unfortunately, record saves, even if ! $citation->exists()

The _count_related function description says:

"Returns the number of related items in the database and in the related object."

The problem is, it counts related objects even if they don't exist in the database, so if you accidentally pass in an empty object, it will cause your validation rules to return TRUE, even though the relationship cannot be saved.

Here's an excerpt from _count_related which shows that it is only checking the object's model name, not whether or not it exists:

Code:

if (strtolower(get_class($obj)) == $class)
{
    $count++;
}

Perhaps I should be checking all my objects before saving, but I think as a precaution that _count_related should only count objects that exist. Or am I missing something?