Welcome Guest, Not a member yet? Register   Sign In
QuickAuth Authentication Library Version 1.0.0
#7

[eluser]Adam Griffiths[/eluser]
[quote author="Dam1an" date="1243443665"][quote author="Adam Griffiths" date="1243443175"]Is it really necessary to have an encrypt() function when all it does is return the sha1? I can understand if it was salted somehow, but it isn't.[/quote]

You should be greatful you're even getting sha1... it was originally md5 Tongue[/quote]

Oh no!

[quote author="Dave Blencowe" date="1243443765"]Hey Adam,

Firstly, thanks for your input.
With regards to the indentation comment it isn't entirely my fault! Big Grin It appears that Github renders the indentation differently to what I am seeing in the NEtbeans IDE so I need to go through and find out why this is before I can correct it. Thank you very much for your link the the style guide though, I will take a look on my trip to Manchester in a while.

The reason behind the separate encrypt() function was to provide an easy way for a developer to specify their own encryption without having to update it several times throughout the code although I am seriously considering adding a salt by default.

As for the active record and form validation comments I shall look in to them for the next version and probably role it out sometime in the next couple of days.

Thank you for your input though and I hope you can continue to help me improve the library over time!

David Blencowe,[/quote]

It's probably because you haven't used tabs all the way through. You're in the unique position that nobody is actually using this library yet, so make it secure before people start using it. Once they update after you fixed the password hashing, all their previous passwords will be busted and useless.


Thanks,
Adam


Messages In This Thread
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 05:26 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 05:41 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 05:43 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 05:52 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 06:01 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 06:02 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 06:06 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-27-2009, 06:14 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-29-2009, 05:04 PM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 11-02-2009, 06:01 AM
QuickAuth Authentication Library Version 1.0.0 - by El Forum - 05-16-2010, 12:47 AM



Theme © iAndrew 2016 - Forum software by © MyBB