Welcome Guest, Not a member yet? Register   Sign In
flexi cart - A comprehensive shopping cart library for CodeIgniter
#23

[eluser]haseydesign[/eluser]
@koichirose

Thanks for the input.

Issue #1: the broken link to http://haseydesign.com/flexi-cart/user_g...#tax_total
This seems to work fine for me, perhaps your browser is jumping to the last position you were viewing on the page before a page refresh? - Or is there something I'm misunderstanding?

Issue #2: Shipping tax rate set as '0' via the config file is being ignored.
This was definitely a bug, the value '0' was being treated as FALSE, and so was being ignored.

I have fixed this problem and made the change to the Github repo.
If you'd prefer to just change the errornous line, its located on line 2060 within flexi_cart_model.php.

Change the following line from:
Code:
$value = (! empty($this->flexi->cart_defaults['shipping'][$column])) ? $this->flexi->cart_defaults['shipping'][$column] : $data;
To:
Code:
$value = (! empty($this->flexi->cart_defaults['shipping'][$column]) || $this->non_negative($this->flexi->cart_defaults['shipping'][$column])) ?
  $this->flexi->cart_defaults['shipping'][$column] : $data;


I haven't had a chance to properly test this yet, so if things are still weird, let me know.



Messages In This Thread
flexi cart - A comprehensive shopping cart library for CodeIgniter - by El Forum - 05-31-2012, 06:18 AM



Theme © iAndrew 2016 - Forum software by © MyBB