Handling controller parameters

I usually define all of the permitted URL parameters on the method definition, with default values set for optional parameters. If it's possible for the order of the parameters to change, I might use logic similar to what you've shown to reassign the values to the correct variables. However, I try to avoid that level of complexity whenever possible.

As InsiteFX inferred, the second parameter of $this->uri->segment() can be very useful for handling optional parameters, though the code you've shown here wouldn't benefit from that.

Bonfire

Practical CodeIgniter 3
CodeIgniter Testing Guide