• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
re-thinking function names or acts on service() and shared_service()

#1
Two functions, ``service()`` and ``shared_service()`` make somebody think that service class returns new instance typically. At first, it was right.
It is turned over by github issue #55. Now, Service class returns shared instance by default.

I think ``service()`` should return shared instance, but I cannot judge whether we should do or not do from now.
Reply

#2
Yes, you're correct. It's long been on my mental to-do list Smile
Practical CodeIgniter 3  • CodeIgniter 4 Foundations - Coming Soon • Vulcan - CLI Tools for CI4
Reply

#3
https://github.com/bcit-ci/CodeIgniter4/...fe87225662

Thank you for fixing it!
Reply

#4
Oh, dang! Sorry I forgot to let you know. My bad. But, you're welcome. Smile
Practical CodeIgniter 3  • CodeIgniter 4 Foundations - Coming Soon • Vulcan - CLI Tools for CI4
Reply


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2017 MyBB Group.