Welcome Guest, Not a member yet? Register   Sign In
re-thinking function names or acts on service() and shared_service()
#1

(This post was last modified: 12-27-2016, 07:25 AM by takekoshi.)

Two functions, ``service()`` and ``shared_service()`` make somebody think that service class returns new instance typically. At first, it was right.
It is turned over by github issue #55. Now, Service class returns shared instance by default.

I think ``service()`` should return shared instance, but I cannot judge whether we should do or not do from now.
Reply
#2

Yes, you're correct. It's long been on my mental to-do list Smile
Reply
#3

https://github.com/bcit-ci/CodeIgniter4/...fe87225662

Thank you for fixing it!
Reply
#4

Oh, dang! Sorry I forgot to let you know. My bad. But, you're welcome. Smile
Reply




Theme © iAndrew 2016 - Forum software by © MyBB