• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Regression: cannot convert a PDF to an image in 3.1.3

#1
This changed somewhere between 3.1.1 and 3.1.3: https://github.com/bcit-ci/CodeIgniter/b....php#L1652

The added condition prevents converting a PDF to an image. getimagesize will always return false in this case. I'm using Imagemagik as the library. If I comment the new block out it will correctly create an image as it did in past versions.
Reply

#2
PDF is not an image format; you've been relying on a bug.
Reply

#3
Hah I figured you'd say that Smile

I extended the library and removed the check. Cheers,
Reply

#4
So instead of correcting the problem you extend the library and undo the check so that you can still use the bug.

Glad your not writing software for me.
What did you Try? What did you Get? What did you Expect?

Joined the CodeIgniter Community in 2009.          ( Skype: insitfx )
Reply

#5
The alternative being, do not use CI's Image Library at all and write my own wrapper for IM. Not worth the effort IMO as this is only used to generate thumbnails.
Reply


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2017 MyBB Group.