Welcome Guest, Not a member yet? Register   Sign In
Error in composer.json on main download link
#1

Should not https://github.com/codeigniter4/framewor...v4.0.3.zip be something like https://github.com/codeigniter4/CodeIgni...v4.0.3.zip?

Installing from https://github.com/codeigniter4/framewor...v4.0.3.zip produces error from composer.json line 32 running :
"bash admin/setup.sh"

There is no admin folder in framework so either it's missing and there is a reason the main download link is referencing framework instead of CodeIgniter4 or the link is wrong.

What should be changed here?
Reply
#2

The Download button on CodeIgniter.com refer to the PHP framework itself. And are the "Manual Installation"; https://codeigniter4.github.io/userguide...anual.html

It's for people not wanting to use Composer, but I think the framework composer.json should not crash like that. You can open an issue on our Github; https://github.com/codeigniter4/CodeIgniter4
Reply
#3

I see but the link you posted to the repo is not the one used by the download link (which I think is the problem) but the link provided is a packed version of https://github.com/codeigniter4/framework which has the composer.json doing the "bash admin/setup.sh" which will fail due to no admin/setup.sh exists.

So the link provided on the main page could be changed (to avoid confusion) to the actual packed Codeigniter repo and not the framework version, I would argue that providing a link to the maintained repo and give the user the ability to choose to use composer might just be easier and give more options.
Reply
#4

codeigniter4/CodeIgniter4 are only for development and contain scripts that should not be used by the general public.

^ This one dosen't work with Composer, sure you can install other stuff with it. But not CodeIgniter itself.

codeigniter4/framework are the correct one in this case, but with a broken composer.json. It's the manual installation, just like CodeIgniter 3.

codeigniter4/appstarter are the one that get's installed and updated with Composer. https://codeigniter4.github.io/userguide...poser.html
Reply
#5

Ok I see, thanks for clarification. It seems that it already exists a PR to remove the faulty commands in composer.json on https://github.com/codeigniter4/framework/pull/8, after that merge it should be fixed.
Reply




Theme © iAndrew 2016 - Forum software by © MyBB