+- CodeIgniter Forums (https://forum.codeigniter.com)
+-- Forum: CodeIgniter 4 (https://forum.codeigniter.com/forumdisplay.php?fid=28)
+--- Forum: CodeIgniter 4 Development (https://forum.codeigniter.com/forumdisplay.php?fid=27)
+--- Thread: PRs for 4.4 are waiting for reviews (/showthread.php?tid=87335)
Pages:
1
2
RE: PRs for 4.4 are waiting for reviews - ozornick - 08-18-2023
1. I changed setAttributes after find in DB.
I need setters after the entity request.
2. In my opinion, I have been using the config without global visibility since the manual. Not a problem
RE: PRs for 4.4 are waiting for reviews - kenjis - 08-20-2023
@ozornick Sorry, I don't get what you really mean.
If you think the documentation is not sufficient,
please point out what specific changes should be made.
Alternatively, sending a PR is the best way.
RE: PRs for 4.4 are waiting for reviews - kenjis - 08-20-2023
There is only one PR remaining!
https://github.com/codeigniter4/CodeIgniter4/issues/7812
RE: PRs for 4.4 are waiting for reviews - ozornick - 08-20-2023
@kenjis nothing depends on you - this is my correction. we discussed the entity and came to the opinion that I should modify the class myself