js_img_removal($match) and valid XHTML

js_img_removal($match) and valid XHTML - Printable Version

+- CodeIgniter Forums (https://forum.codeigniter.com)
+-- Forum: Archived Discussions (https://forum.codeigniter.com/forumdisplay.php?fid=20)
+--- Forum: Archived Development & Programming (https://forum.codeigniter.com/forumdisplay.php?fid=23)
+--- Thread: js_img_removal($match) and valid XHTML (/showthread.php?tid=10609)

js_img_removal($match) and valid XHTML - El Forum - 08-06-2008

[eluser]pistolPete[/eluser]
Hi,

I just discovered something, but I don't know if it's considered a bug:

I tried to generate valid XHTML 1.0, therefore the <img> tag must be closed (<img >).
In CI 1.6.3, file Input.php line 925 in function _js_img_removal($match) the closing "/" gets removed...

Took me a while to find out it's not tinyMCE's fault...

Please have a look at it!

Thanks,

Pete

js_img_removal($match) and valid XHTML - El Forum - 10-03-2008

[eluser]5n4K3[/eluser]
[quote author="pistolPete" date="1218047430"]Hi,

I just discovered something, but I don't know if it's considered a bug:

I tried to generate valid XHTML 1.0, therefore the <img> tag must be closed (<img >).
In CI 1.6.3, file Input.php line 925 in function _js_img_removal($match) the closing "/" gets removed...

Took me a while to find out it's not tinyMCE's fault...

Please have a look at it!

Thanks,

Pete[/quote]
Yes, there is a problem...but is in line 688 in Input.php file

Code:
$str = preg_replace_callback("#<img\s*([^>]*?)(>|$)#si", array($this, '_js_img_removal'), $str);

change line to:

Code:
$str = preg_replace_callback("#<img\s*([^>]*?)(\/>|$)#si", array($this, '_js_img_removal'), $str);

change the regexp and now have xhtml valid images! :p

pd: i will send a bug ticket :p

Grettings!