+- CodeIgniter Forums (https://forum.codeigniter.com)
+-- Forum: Archived Discussions (https://forum.codeigniter.com/forumdisplay.php?fid=20)
+--- Forum: Archived Development & Programming (https://forum.codeigniter.com/forumdisplay.php?fid=23)
+--- Thread: Model Error (/showthread.php?tid=21475)
Model Error - El Forum - 08-11-2009
[eluser]georgerobbo[/eluser]
I have a model which pulls content from a MySQL database. When I use the query in my controller it works fine, however I am having difficulties in the model. The error being returned is:
Quote:A PHP Error was encountered
Severity: Warning
Message: Invalid argument supplied for foreach()
Filename: views/content.php
Line Number: 13
This is my code:
Code:
<?php
class Welcome extends Controller {
function Welcome()
{
parent::Controller();
}
function index()
{
$data['title'] = 'Home';
$this->load->model('Ros_sidecont');
$data['sidecont'] = $this->Ros_sidecont->get_sidecont();
$this->load->view('meta', $data);
$this->load->view('header');
$this->load->view('panel');
$this->load->view('content', $data);
$this->load->view('footer');
}
}
?>Code:
<?php
class Ros_sidecont extends Model {
function Ros_sidecont()
{
parent::Model();
}
function get_sidecont()
{
$query = $this->db->query('SELECT ros_sidecont_title, ros_sidecont_text FROM ros_sidecont');
$data['sidecont'] = array();
foreach($query->result_array() as $row)
{
$data['sidecont'][] = $row;
}
}
}Code:
<div id="content">
<?php foreach($pagecont as $content_item):?>
<h4><?php echo $content_item['ros_sidecont_title']; ?></h4>
<p><?php echo $content_item['ros_sidecont_text']; ?></p>
<?php endforeach; ?>
</div>
<div id="sidebar">
<?php foreach($sidecont as $side_item):?>
<div class="sideitem">
<div class="sidetitle">
<h3><?php echo $side_item['ros_sidecont_title']; ?></h3>
</div>
<p><?php echo $side_item['ros_sidecont_text']; ?></p>
</div>
<?php endforeach; ?>
</div>
</div>Model Error - El Forum - 08-11-2009
[eluser]OES[/eluser]
You are not returning anything from the get_sidecont model.
instead of
Code:
foreach($query->result_array() as $row)
{
$data['sidecont'][] = $row;
}do
Code:
return $query->result_array()Model Error - El Forum - 08-11-2009
[eluser]Johan André[/eluser]
I usually do it like this:
Code:
// The model
class Simple_model extends Model
{
function __construct()
{
parent::Model();
}
function get_all()
{
$this->db->select('name, phone');
$this->db->from('adressbook');
return $this->db->get()->result_array();
}
}Code:
// The view
<? if(count($data)) { ?>
<ul>
<? foreach($data AS $item) : ?>
<li><?=$item['name']?>, <?=$item['phone']?></li>
<? endforeach; ?>
</ul>
<? } else { ?>
<p>Nothing to display</p>
<? } ?>Model Error - El Forum - 08-11-2009
[eluser]georgerobbo[/eluser]
[quote author="OES" date="1250005005"]You are not returning anything from the get_sidecont model.
instead of
Code:
foreach($query->result_array() as $row)
{
$data['sidecont'][] = $row;
}do
Code:
return $query->result_array()I don't understand why the model doesn't return anything. When I have the query in my controller it works perfectly?
Model Error - El Forum - 08-11-2009
[eluser]Johan André[/eluser]
When you use the code in your controller it populates the $data-array and sends it to the view. Remember that the $data-array in the model is not the same as the $data-array in the controller. The array is a property of the class refeering to it.
The model methods that are used to fetch model-data to the controller needs to return something (ie end the method with return $something
.
Model Error - El Forum - 08-11-2009
[eluser]georgerobbo[/eluser]
[quote author="OES" date="1250005005"]You are not returning anything from the get_sidecont model.
instead of
Code:
foreach($query->result_array() as $row)
{
$data['sidecont'][] = $row;
}do
Code:
return $query->result_array()Such a more efficient way of doing it. Thank you very much.