+- CodeIgniter Forums (https://forum.codeigniter.com)
+-- Forum: Archived Discussions (https://forum.codeigniter.com/forumdisplay.php?fid=20)
+--- Forum: Archived Libraries & Helpers (https://forum.codeigniter.com/forumdisplay.php?fid=22)
+--- Thread: PyroCMS v0.9.9 (/showthread.php?tid=25699)
PyroCMS v0.9.9 - El Forum - 04-19-2010
[eluser]Isern Palaus[/eluser]
[quote author="Phil Sturgeon" date="1271688687"]Uploaded now. Remember these are old un-supported modules that I refuse to maintain, so if they are broken you will need to fix them. :-) They are also only compatible with v0.9.7 so you will need to upgrade them.[/quote]
Did you pushed? I can't found it!
Thanks in advance!
PyroCMS v0.9.9 - El Forum - 04-19-2010
[eluser]Phil Sturgeon[/eluser]
My bad, push failed and I was flipping between so many terminal windows I missed it.
Pushed
PyroCMS v0.9.9 - El Forum - 04-19-2010
[eluser]Isern Palaus[/eluser]
Thank you!
I'm going to adapt the news now. Wish my luck!
Thanks
Isern
PyroCMS v0.9.9 - El Forum - 04-19-2010
[eluser]Isern Palaus[/eluser]
I got it working now! I've to adapt to the admin panel new style but it's cropping perfectly.
I also want to add the possibility of associate an album to a new :-)!
PyroCMS v0.9.9 - El Forum - 04-19-2010
[eluser]Isern Palaus[/eluser]
pyrocms-news-module modified: http://bitbucket.org/ipalaus/pyrocms-news-module/.
PyroCMS v0.9.9 - El Forum - 04-20-2010
[eluser]Phil Sturgeon[/eluser]
What version are you running from? modules/third_party/news/ suggests you are using something older than the current version...
Also, the current master is missing models and the frontend controller.
Could you instead make these changes as a GitHub fork? It makes life a LOT easier for me to integrate changes that way.
PyroCMS v0.9.9 - El Forum - 04-20-2010
[eluser]Isern Palaus[/eluser]
No problem, doing right now :-)!
PyroCMS v0.9.9 - El Forum - 04-20-2010
[eluser]Isern Palaus[/eluser]
Hello Phil,
You can grab now from git: http://github.com/ipalaus/pyrocms/commits/master
PyroCMS v0.9.9 - El Forum - 04-20-2010
[eluser]Dan Horrigan[/eluser]
Nice work Isern. A quick comment though. You don't have to commit after every file you change. Just change the whole lot, then commit. If you did it to document the changes you made, then you could have just used comments in the code. The Diff would have shown your changes.
It is really just personal preference I guess. All well, back to programming instead of nit-picking :-)
Nice work.
PyroCMS v0.9.9 - El Forum - 04-20-2010
[eluser]Isern Palaus[/eluser]
[quote author="Dan Horrigan" date="1271792995"]Nice work Isern. A quick comment though. You don't have to commit after every file you change. Just change the whole lot, then commit. If you did it to document the changes you made, then you could have just used comments in the code. The Diff would have shown your changes.
It is really just personal preference I guess. All well, back to programming instead of nit-picking :-)
Nice work.[/quote]
Hello Dan Horrigan,
In my SVN times I was educated to commit after every change was made. This is not a way today?
Sorry, can you explain me what you mean with 'nit-picking'? As you can see... my English is not the best. lol
Thank you!