+- CodeIgniter Forums (https://forum.codeigniter.com)
+-- Forum: Archived Discussions (https://forum.codeigniter.com/forumdisplay.php?fid=20)
+--- Forum: Archived Development & Programming (https://forum.codeigniter.com/forumdisplay.php?fid=23)
+--- Thread: AR update bug when calculating with fields (/showthread.php?tid=5057)
AR update bug when calculating with fields - El Forum - 01-03-2008
[eluser]xwero[/eluser]
I have a simple update query
Quote:update menu set number = number-1 where number > ?But when i rewrite it as an AR update query
Code:
$data = array('number' => 'number-1');
$this->db->where('number >',$row->number);
$this->db->update('menu',$data);Quote:UPDATE menu SET number = 'number-1' WHERE number > '2'And it subtracts all records.
If no records were subtracted i could at least see the logic but this is just weird to me.
AR update bug when calculating with fields - El Forum - 01-03-2008
[eluser]Derek Allard[/eluser]
Funny. I just added this to AR last night, but it hasn't worked its way into the svn yet.
Quote:set() will also accept an optional third parameter ($escape), that will prevent data from being escaped if set to FALSE. To illustrate the difference, here is set() used both with and without the escape parameter.
$this->db->set('field', 'field+1', FALSE);
$this->db->update('mytable');
// gives INSERT INTO mytable (field) VALUES (field+1)
$this->db->set('field', 'field+1');
$this->db->update('mytable');
// gives INSERT INTO mytable (field) VALUES ('field+1')
This is will be in the svn shortly.
AR update bug when calculating with fields - El Forum - 01-03-2008
[eluser]xwero[/eluser]
Great, i didn't know about the set method but once it is available i'm going to use this nice addition.
Another small addition in the AR class would be selecting the wildcard position for the like method; both (default), left, right
Code:
/**
* Like
*
* Generates a &#xLI;KE% portion of the query. Separates
* multiple calls with AND
*
* @access public
* @param mixed
* @param mixed
* @return object
*/
function like($field, $match = '',$wildcard = 'both') // changed
{
return $this->_like($field, $match, 'AND ', $wildcard);
}
// --------------------------------------------------------------------
/**
* OR Like
*
* Generates a &#xLI;KE% portion of the query. Separates
* multiple calls with OR
*
* @access public
* @param mixed
* @param mixed
* @return object
*/
function orlike($field, $match = '',$wildcard = 'both') // changed
{
return $this->_like($field, $match, 'OR ',$wildcard); // changed
}
// --------------------------------------------------------------------
/**
* Like
*
* Called by like() or orlike()
*
* @access private
* @param mixed
* @param mixed
* @param string
@param string
* @return object
*/
function _like($field, $match = '', $type = 'AND ', $wildcard = 'both')
{
if ( ! is_array($field))
{
$field = array($field => $match);
}
foreach ($field as $k => $v)
{
$prefix = (count($this->ar_like) == 0) ? '' : $type;
$v = $this->escape_str($v);
// begin change
switch($wildcard)
{
case 'left': $this->ar_like[] = $prefix." $k LIKE '%{$v}'"; break;
case 'right': $this->ar_like[] = $prefix." $k LIKE '{$v}%'"; break;
default: $this->ar_like[] = $prefix." $k LIKE '%{$v}%'"; break;
}
// end change
}
return $this;
}AR update bug when calculating with fields - El Forum - 01-03-2008
[eluser]Derek Allard[/eluser]
Thats been in there since Dec 17
