CodeIgniter Forums
re-thinking function names or acts on service() and shared_service() - Printable Version

+- CodeIgniter Forums (https://forum.codeigniter.com)
+-- Forum: CodeIgniter 4 (https://forum.codeigniter.com/forum-28.html)
+--- Forum: CodeIgniter 4 Discussion (https://forum.codeigniter.com/forum-31.html)
+--- Thread: re-thinking function names or acts on service() and shared_service() (/thread-66980.html)



re-thinking function names or acts on service() and shared_service() - takekoshi - 12-27-2016

Two functions, ``service()`` and ``shared_service()`` make somebody think that service class returns new instance typically. At first, it was right.
It is turned over by github issue #55. Now, Service class returns shared instance by default.

I think ``service()`` should return shared instance, but I cannot judge whether we should do or not do from now.


RE: re-thinking function names or acts on service() and shared_service() - kilishan - 12-27-2016

Yes, you're correct. It's long been on my mental to-do list Smile


RE: re-thinking function names or acts on service() and shared_service() - takekoshi - 01-14-2017

https://github.com/bcit-ci/CodeIgniter4/commit/954e7d63e462541496ad0438a800a9fe87225662

Thank you for fixing it!


RE: re-thinking function names or acts on service() and shared_service() - kilishan - 01-14-2017

Oh, dang! Sorry I forgot to let you know. My bad. But, you're welcome. Smile