+- CodeIgniter Forums (https://forum.codeigniter.com)
+-- Forum: CodeIgniter 4 (https://forum.codeigniter.com/forumdisplay.php?fid=28)
+--- Forum: CodeIgniter 4 Feature Requests (https://forum.codeigniter.com/forumdisplay.php?fid=29)
+--- Thread: The Request class rework (/showthread.php?tid=80715)
The Request class rework - iRedds - 12-07-2021
PHP Code:
class Request
{
/**
* @var array
*/
protected $data = [];
/**
* Get data from collection by key and request method
* @param string $key
* @return mixed
*/
public function __get(string $key){}
/**
* Set data for outgoing request
* @param string $key
* @param string $value
*/
public function __set(string $key, string $value){}
/**
* Get data from collection by key and request method
* Default value can be set
* @param string $key
* @param null $default
* @return mixed
*/
public function get(string $key, $default = null){}
/**
* Get data collection by request method
* @return array
*/
public function getAll(){}
/**
* Get data from a query string
* @param string $key
* @param null $default
* @return mixed
*/
public function query(string $key, $default = null){}
}
PHP Code:
class IncomingRequest extends Request
{
/**
* Disable the ability to set data for incoming requests
*/
public function __set(string $key, string $value){ return null;}
}
PHP Code:
//url host/path/?a=1&b=2&c=3 with POST method a=2&b=3
echo $request->a; // 2 alias for get('a');
echo $request->b; // 3
echo $request->get('a'); // 2
echo $request->get('c', 4); // 4
echo $request->getAll(); // ["a" => 2, "b" => 3]
echo $request->query('a'); // 1
echo $request->query('b'); // 2
//no more getGet, getPost, getGetPost, getPostGet, etc
//no filtering data, only raw
RE: The Request class rework - includebeer - 12-08-2021
It's only my opinion, but I find it even more confusing... I don't see that as an improvement. Your get() method returns data from $_POST. Why not from $_GET? What's the use case for get('c', 4) if it completely ignores c and always return 4?
RE: The Request class rework - kenjis - 12-08-2021
I feel your APIs are a bit cleaner, but
I'm not sure what the benefit would be to change the current APIs.
As includebeer says it may be more confusing for the current users.
Also, what about compliance with PSR-7?
RE: The Request class rework - iRedds - 12-08-2021
(12-08-2021, 04:37 PM)includebeer Wrote: It's only my opinion, but I find it even more confusing... I don't see that as an improvement. Your get() method returns data from $_POST. Why not from $_GET? What's the use case for get('c', 4) if it completely ignores c and always return 4?
Thank you. Maybe I forgot, but it seems to me that this is the first time I get feedback on this forum thread.
It seems to me that a possible reason why you do not understand why the get() method works with _POST, and not with _GET, is that you see the http method in the basis of the request, and I see the data.
The get() method works with the current HTTP method. Be it GET/POST/PUST/DELETE/PATCH/etc
That is, get() ! == _GET. get() === get the request data.
get('c', 4) returns 4 because there is no "c" parameter in the current POST request. Therefore, the get() method returns a default value.
(12-08-2021, 05:09 PM)kenjis Wrote: I feel your APIs are a bit cleaner, but
I'm not sure what the benefit would be to change the current APIs.
As includebeer says it may be more confusing for the current users.
Also, what about compliance with PSR-7?
I have already commented on your PR. Let me explain. Now you cannot get the default value of a variable if it is not in the request. If the variable is not defined you will always get NULL. Although NULL may be one of the expected values.
Yes. Users may not immediately understand the nature of the changes.
PSR-7 does not regulate in any way how to get the request data.
RE: The Request class rework - includebeer - 12-09-2021
Ok, now I understand your logic. But I'm still not sure it's an improvement of the current class. Maybe I'm old school, but I'm not a fan of magic stuff happening behind the scene. For me it's easier to understand what is going on if I call a function to retrieve the POST data or the GET data and not a function that will return one or the other depending on the http method.
RE: The Request class rework - kenjis - 12-09-2021
(12-08-2021, 08:21 PM)iRedds Wrote: It seems to me that a possible reason why you do not understand why the get() method works with _POST, and not with _GET, is that you see the http method in the basis of the request, and I see the data.
The get() method works with the current HTTP method. Be it GET/POST/PUST/DELETE/PATCH/etc
That is, get() ! == _GET. get() === get the request data.
get('c', 4) returns 4 because there is no "c" parameter in the current POST request. Therefore, the get() method returns a default value.
I also did not understand your intent.
And I think the `get()` is difficult to understand, because its behavior changes in the context.
I prefer something like `getGet()`, `getPost()`, `getPut()`...
RE: The Request class rework - iRedds - 12-09-2021
1. Routes depend on the HTTP method.
PHP Code:
$request->get('resource', 'Controller::getRequest')
$request->post('resource', 'Controller::postRequest')
2. Even if the route listens to multiple HTTP methods, the controller still has to separate the logic for different methods.
PHP Code:
$request->match(['get', 'post'], 'resource', 'Controller::request')
//...
if ($this->request->getMethod() == 'post') { }
else { }
/* By the way, why are there no isPost/isGet/isMethodName methods yet? */
3. The IncomingRequest class already has a getVar() method, which is independent of the HTTP method.
Basically, you always want data sent by a specific HTTP method.
For example, you won't call getDelete() if there was a GET or POST or PUT request.
The only time to qualify a request method is any HTTP method other than GET + a query string.
RE: The Request class rework - kenjis - 12-10-2021
iRedds
Your proposal is the same as Laravel, right?
https://laravel.com/docs/8.x/requests#retrieving-an-input-value
RE: The Request class rework - iRedds - 12-10-2021
(12-10-2021, 02:39 AM)kenjis Wrote: iRedds
Your proposal is the same as Laravel, right?
https://laravel.com/docs/8.x/requests#retrieving-an-input-value
Yes you are right.
RE: The Request class rework - kenjis - 12-10-2021
Symfony
Quote: request: equivalent of $_POST;https://symfony.com/doc/current/components/http_foundation.html#accessing-request-data
query: equivalent of $_GET ($request->query->get('name'));
cookies: equivalent of $_COOKIE;
attributes: no equivalent - used by your app to store other data (see below);
files: equivalent of $_FILES;
server: equivalent of $_SERVER;
headers: mostly equivalent to a subset of $_SERVER ($request->headers->get('User-Agent')).
CakePHP
https://book.cakephp.org/4/en/controllers/request-response.html#query-string-parameters
Yii
https://www.yiiframework.com/doc/guide/2.0/en/runtime-requests#request-parameters
Slim
https://www.slimframework.com/docs/v4/objects/request.html#the-request-body