ArgumentCountError Too few arguments to function ::__construct()

ArgumentCountError Too few arguments to function ::__construct() - Printable Version

+- CodeIgniter Forums (https://forum.codeigniter.com)
+-- Forum: CodeIgniter 4 (https://forum.codeigniter.com/forumdisplay.php?fid=28)
+--- Forum: CodeIgniter 4 Support (https://forum.codeigniter.com/forumdisplay.php?fid=30)
+--- Thread: ArgumentCountError Too few arguments to function ::__construct() (/showthread.php?tid=87661)

ArgumentCountError Too few arguments to function ::__construct() - destor77 - 05-15-2023

I am trying to implement hexagonal architecture in CI4, I want to make a method to save in the database which actions were executed, for this I am doing the following:
app/PunkCore/Shared/Interfaces/Repository/UserActivityRepositoryInterface.php

PHP Code:
<?php
namespace App\PunkCore\Shared\Interfaces\Repository;

use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\ResponseInterface;

interface UserActivityRepositoryInterface
{
    public function saveActivity(
        string $method,
        bool $succeed,
        RequestInterface $request,
        ResponseInterface $response): void;
} 

app/PunkCore/Shared/Infrastructure/Repository/UserActivityRepository.php

PHP Code:
<?php

namespace App\PunkCore\Shared\Infrastructure\Repository;

use App\PunkCore\Shared\Interfaces\Repository\UserActivityRepositoryInterface;

use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\ResponseInterface;

use App\Models\UserActivity;

class UserActivityRepository implements UserActivityRepositoryInterface
{

    public function saveActivity(
        string $method,
        bool $succeed,
        RequestInterface $request,
        ResponseInterface $response): void
    {
        $user = auth()->user();
        UserActivity::create([
            'method' => $method,
            'succeed' => $succeed,
            'user' => $user->username,
            'ip' => $request->getIPAddress(),
            'date' => date('Y-m-d H:i:s'),
            'request' => $request->getBody(),
            'response' => $response->getBody(),
        ]);
    }
} 

app/PunkCore/Shared/Interfaces/Services/UserActivityServiceInterface.php

PHP Code:
<?php
namespace App\PunkCore\Shared\Interfaces\Services;

use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\ResponseInterface;

interface UserActivityServiceInterface
{
    public function logUserActivity(
        string $method,
        bool $succeed,
        string $request,
        string $response
    ): void;
} 

app/PunkCore/Shared/Application/UserActivityService.php

PHP Code:
<?php
namespace App\PunkCore\Shared\Application;

use  App\PunkCore\Shared\Interfaces\Services\UserActivityServiceInterface;
use  App\PunkCore\Shared\Interfaces\Repository\UserActivityRepositoryInterface;

use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\ResponseInterface;

class UserActivityService implements UserActivityServiceInterface
{
    private $userActivityRepository;

    public function __construct(UserActivityRepositoryInterface $userActivityRepository)
    {
        $this->userActivityRepository = $userActivityRepository;
    }

    public function logUserActivity(
        string $method,
        bool $succeed,
        RequestInterface $request,
        ResponseInterface $response): void
    {
        $this->userActivityRepository->saveActivity($method, $succeed, $request, $response);
    }
} 

But when I want to configure the controller it returns this error:

ArgumentCountError

Too few arguments to function App\Controllers\Admin\AdminController::__construct(), 0 passed in /mnt/d/html/punkframework/system/CodeIgniter.php on line 906 and exactly 4 expected
ArgumentCou
ArgumentCountError
Too few arguments to function App\Controllers\Admin\AdminController::__construct(), 0 passed in /mnt/d/html/punkframework/system/CodeIgniter.php on line 906 and exactly 4 expected
APPPATH/Controllers/Admin/AdminController.php at line 42

Code:
        $this->response = $response;

        $this->logger = $logger;



        //$this->userActivityRepository = new UserActivityRepository();

        //$this->userActivityService = new UserActivityService($this->userActivityRepository);

    }*/



    public function __construct(RequestInterface $request, ResponseInterface $response, UserActivityService $userActivityService, UserActivityRepositoryInterface $userActivityRepository)

    {

        $this->request = $request;

        $this->response = $response;

        $this->userActivityService = $userActivityService;

        $this->userActivityRepository = $userActivityRepository;

    }

49

SYSTEMPATH/CodeIgniter.php : 906 — App\Controllers\Admin\AdminController->__construct ()

Code:
899 * 900 * @return Controller 901 */ 902 protected function createController() 903 { 904 assert(is_string($this->controller)); 905 906 $class = new $this->controller(); 907 $class->initController($this->request, $this->response, Services::logger()); 908 909 $this->benchmark->stop('controller_constructor'); 910 911 return $class; 912 } 913

app/Controllers/Admin/AdminController.php

PHP Code:
<?php

namespace App\Controllers\Admin;

use Psr\Log\LoggerInterface;

use CodeIgniter\API\ResponseTrait;
use App\Controllers\BaseController;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\ResponseInterface;

use App\PunkCore\Shared\Interfaces\Repository\UserActivityRepositoryInterface;
use App\PunkCore\Shared\Infrastructure\Repository\UserActivityRepository;
use App\PunkCore\Shared\Interfaces\Services\UserActivityServiceInterface;
use App\PunkCore\Shared\Application\UserActivityService;

class AdminController extends BaseController
{
    use ResponseTrait;

    protected $request;
    protected $response;
    protected $logger;
    protected $userActivityService;
    protected $userActivityRepository;  

    public function __construct(RequestInterface $request, ResponseInterface $response, UserActivityService $userActivityService, UserActivityRepositoryInterface $userActivityRepository)
    {
        $this->request = $request;
        $this->response = $response;
        $this->userActivityService = $userActivityService;
        $this->userActivityRepository = $userActivityRepository;
    }
    

    public function index()
    {
        if (!auth()->loggedIn()) {
            return view('admin/Auth/login');
        }
        
    }

    public function dashboard()
    {
        return view('admin/Auth/dashboard');
    }

    public function login()
    {
        echo'<pre>';print_r($this->request->getBody());echo'</pre>';
       
        $this->userActivityService->logUserActivity(__CLASS__ . '-' . __METHOD__, true, $this->request, $this->response);
        
    }

    public function register()
    {

    }

    public function logout()
    {
        auth()->logout();
    }
} 

and I don't know where I am failing.

RE: ArgumentCountError Too few arguments to function ::__construct() - kenjis - 05-19-2023

The controller in CI4 does not have the __construct() method.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/system/Controller.php
So if you add __construct(), no parameters are passed by the framework.

RE: ArgumentCountError Too few arguments to function ::__construct() - destor77 - 05-20-2023

thanks!