+- CodeIgniter Forums (https://forum.codeigniter.com)
+-- Forum: CodeIgniter 4 (https://forum.codeigniter.com/forumdisplay.php?fid=28)
+--- Forum: CodeIgniter 4 Development (https://forum.codeigniter.com/forumdisplay.php?fid=27)
+--- Thread: We need more reviewers! (/showthread.php?tid=88437)
Pages:
1
2
We need more reviewers! - kenjis - 09-07-2023
We have many PRs waiting for reviews and approvals.
https://github.com/codeigniter4/CodeIgniter4/pulls
If there is a PR you are interested in, please test and review it and comment on the results on GitHub.
PRs not approved will not be merged.
We really welcome your contributions!
RE: We need more reviewers! - ozornick - 09-07-2023
Sadly, there are few active users. Personally, I can't understand everything from PR, especially if it's part of an internal system (router, uri, github actions..)
RE: We need more reviewers! - kenjis - 09-07-2023
If you mean that it is difficult to understand a PR with seeing the diffs on the PR page on GitHub,
yes, we may need to see whole code base to understand the changes.
I recommend you install gh command.
https://cli.github.com/
and you can check out the PR branch to your local environment.
E.g.,
Code:
$ gh pr checkout 7913RE: We need more reviewers! - ozornick - 09-07-2023
The code is perfectly visible in "Files changed".
The problem is precisely in understanding the changes.
I see that the proposed code passes tests, is written without errors, but do I need to accept it as corrected? I can't fully understand all the logic that the code affects.
Let's say we change the filters: I know that the code changes the sorting of the array or rename vars. Is she needed there? It's more about business rules than PHP
RE: We need more reviewers! - tarcisiodev1 - 09-09-2023
(09-07-2023, 04:55 PM)kenjis Wrote: We have many PRs waiting for reviews and approvals.
https://github.com/codeigniter4/CodeIgniter4/pulls
If there is a PR you are interested in, please test and review it and comment on the results on GitHub.
PRs not approved will not be merged.
We really welcome your contributions!
Hi there,
I'm new to CodeIgniter and excited to start contributing. I saw your message about testing and reviewing pull requests (PRs) in the CodeIgniter repository. As a beginner, I'm eager to learn and help out. Could you please share some tips on how to get involved and understand the project better?
Your guidance would be greatly appreciated!
RE: We need more reviewers! - kenjis - 09-09-2023
@tarcisiodev1 Welcome!
See the docs on Contributing:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/README.md
especially
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md
See the in-progress User Guide as references:
https://codeigniter4.github.io/CodeIgniter4/
This is the User Guide of the `develop` branch.
If you have any question, feel free to ask.
RE: We need more reviewers! - kenjis - 09-09-2023
(09-07-2023, 11:40 PM)ozornick Wrote: Let's say we change the filters: I know that the code changes the sorting of the array or rename vars. Is she needed there? It's more about business rules than PHP
If you do not know what the specifications should be, you do not know if the change is correct.
In rare cases, the specification is not clear.
Basically, the User Guide is the specification, but it is not always detailed.
In any case, if you do not know how it should behave, we will need to discuss it first.
Without a common goal, it is impossible to test/review.
RE: We need more reviewers! - JanFromHamburg - 11-18-2023
(09-09-2023, 04:15 PM)kenjis Wrote: @tarcisiodev1 Welcome!
See the docs on Contributing:
...
See the in-progress User Guide as references:
...
If you have any question, feel free to ask.
Hi all & @kenjis
I am new to contributing on github as @tarcisiodev1 as well. I know you are all contributing a lot of time already (thank you!), but what would you think about holding an 'Onboarding Session for Newbies' via Zoom or alike for like 4 or 2 times a year?
[url=https://forum.codeigniter.com/member.php?action=profile&uid=78908][/url]
RE: We need more reviewers! - ramonpuig - 09-19-2024
in my humble opinion, creating this forum for support only is a bad idea, and it would be great if the Codeigniter had section in StackExchange or StackOverflow, in order to get points for helping others. I dont know just an idea.
RE: We need more reviewers! - kenjis - 09-20-2024
https://stackoverflow.com/questions/tagged/codeigniter-4