Return values

[eluser]Aethedor[/eluser]
[quote author="xwero" date="1223389013"]Most your remarks have to do with a wrong code documentation, right?[/quote]
No, it's about inconsistancy in the return values. It's about not getting back from a function what you expect, which can result in undesired code behaviour, which can result into a security problem.

For the Language library i can say that the $lang variable is in the language file, so if it's defined in the library developers will not know there is something wrong with the language file they want to load.

Should the function not check $lang is an array after the language file is included and raise an error if it's not? It now looks a bit hackish to me. These kind of checks make CodeIgniter more robust.

For the Validation library when will the methods return NULL?

When the 2 if-statements result into a false. The function just ends without a return, therefor returning null (void).

You should have some patience the EL developers are hard at work to get their bread and butter application out of the door which is already late.

Oke, but after 4 days I expected at least a "we're busy, we'll get back to you" kind of reply. The forum now looks pretty much dead to me...