MeNeedz Auth

[eluser]meteor[/eluser]

Code:

$register_input_config = $this->input_config['register'];
        $user_identifier = $this->CI->input->post($register_input_config['identifier'], TRUE);
        $user_password = $this->CI->input->post($register_input_config['password'], TRUE);
        $user_email = $this->CI->input->post($register_input_config['email'], TRUE);
        $user_primary_key = $this->CI->input->post($register_input_config['primary_key'], TRUE);  
if($user_identifier == FALSE OR $user_password == FALSE OR $user_identifier == "" OR $user_password == "" OR ($this->use_email == TRUE AND ($user_email == FALSE OR $user_email == "")))
        {
            return FALSE;
        }

As far as I understand, above fragment of code just gets post data and checks what is available and what is not ... It might be replaced by validated data passed in the form of arguments to the register function in my opinion. This way we would avoid validating twice and shorten the function a bit ...

What do you think ?