[eluser]sophistry[/eluser]
that's cool! thanks for sharing that code.
what would happen if you put an errordocument directive in your .htaccess file? would that solve this problem too? i have not tried it, but putting a single directive in the webserver config file is more appealling to me than extending the router class... just curious if you use apache and/or have tried something like this:
Code:
ErrorDocument 404 /page_not_found
and then make a page_not_found controller. would that directive run properly if put after the mod_rewrite stuff too? can the errordocument handle parameters in the parameters? hmnnn... just talking off the tips of my fingers...
also, before you go extending the core files you should note that the exceptions class show404() function logs the 404 error before displaying the page:
Code:
/**
* 404 Page Not Found Handler
*
* @access private
* @param string
* @return string
*/
function show_404($page = '')
{
$heading = "404 Page Not Found";
$message = "The page you requested was not found.";
log_message('error', '404 Page Not Found --> '.$page);
echo $this->show_error($heading, $message, 'error_404');
exit;
}
so, you could add this line to the custom404() function:
Code:
log_message('error', '404 Page Not Found --> '.$segment_string);
finally, you might want to pass the $segments argument to the custom404() method so that it can use the mistyped/erroneous controller name to help the user.
best... and let us know if you decide to try out the apache errordocument directive.
