Upload File Bug

[eluser]Unknown[/eluser]
Hopefully this helps. I tried every variation of the posts to try to get CI to accept PDF, INDD, AI, ZIP files and more. Messing with the mime types did not seem to help. I found a fix to add to the Upload.php file within the is_allowed_filetype function.

The problem seems to be within the foreach loop. I don't claim to be a good programmer, but I think the fact that within every condition in this loop, there is a return true or return false which breaks the loop?? (feel free to correct me if I am wrong)

Here is my updated code:

Code:

function is_allowed_filetype()
    {
        
        if (count($this->allowed_types) == 0 OR ! is_array($this->allowed_types))
        {
            $this->set_error('upload_no_file_types');
            return FALSE;
        }

        $image_types = array('gif', 'jpg', 'jpeg', 'png', 'jpe');
        
        /*
            Experienced errors with file types
            PDF     = application/pdf
            ZIP     = application/octet-stream
            INDD    = application/octet-stream
            ZIP     = application/zip
            AI      = application/postscript
        */
        $error_types = array(
                            'application/pdf',
                            'application/octet-stream',
                            'application/zip',
                            'application/postscript'
                            );
        
        foreach ($this->allowed_types as $val)
        {
            $mime = $this->mimes_types(strtolower($val));
                        
            // Images get some additional checks
            if (in_array($val, $image_types))
            {
                
                if (getimagesize($this->file_temp) === FALSE)
                {                    
                    // Added this condition for the error types
                    if (in_array($this->file_type, $error_types, TRUE))
                    {
                        return TRUE;
                    }
                    else
                    {
                        return FALSE;
                    }
                }
            }
            
            if (is_array($mime))
            {
                if (in_array($this->file_type, $mime, TRUE))
                {
                    return TRUE;
                }
            }
            else
            {
                if ($mime == $this->file_type)
                {
                    return TRUE;
                }    
            }        
        }
        
        return FALSE;
    }

If you add the file types you are experiencing errors with in that $error_types array, then the upload function works with those files you experience issues with where the mime type does not fix.

I hope this helps others who had the same issues as me.