Welcome Guest, Not a member yet? Register   Sign In
Solution to session data loss when using AJAX
#17

[eluser]slowgary[/eluser]
Collisions are one concern. I haven't dug through an extensive amount of native CI code, but I always just assume it to be of the highest quality. That being said, I'm a little surprised at the code I see in the session class.

First:
Code:
while (strlen($new_sessid) < 32)
{
    $new_sessid .= mt_rand(0, mt_getrandmax());
}

Maybe I'm being picky here, but why calculate a string's length 32 times? Since it's a fixed length, it would definitely be faster using a for() loop:
Code:
for($i = 0; $i < 32; $i++)
{
    $new_sessid .= mt_rand(0, mt_getrandmax());
}

Also:
Code:
'session_id'     => md5(uniqid($sessid, TRUE))
By hashing a uniqid(), isn't it actually INCREASING the likelihood of a collision?


Messages In This Thread
Solution to session data loss when using AJAX - by El Forum - 12-17-2009, 06:15 AM
Solution to session data loss when using AJAX - by El Forum - 12-17-2009, 06:48 AM
Solution to session data loss when using AJAX - by El Forum - 12-17-2009, 07:12 AM
Solution to session data loss when using AJAX - by El Forum - 03-13-2010, 04:17 PM
Solution to session data loss when using AJAX - by El Forum - 05-10-2010, 06:33 AM
Solution to session data loss when using AJAX - by El Forum - 07-27-2010, 12:49 AM
Solution to session data loss when using AJAX - by El Forum - 10-11-2010, 03:31 PM
Solution to session data loss when using AJAX - by El Forum - 10-11-2010, 04:49 PM
Solution to session data loss when using AJAX - by El Forum - 10-11-2010, 05:29 PM
Solution to session data loss when using AJAX - by El Forum - 10-11-2010, 06:47 PM
Solution to session data loss when using AJAX - by El Forum - 10-12-2010, 12:33 AM
Solution to session data loss when using AJAX - by El Forum - 10-12-2010, 06:29 AM
Solution to session data loss when using AJAX - by El Forum - 10-12-2010, 07:52 AM
Solution to session data loss when using AJAX - by El Forum - 10-12-2010, 08:06 AM
Solution to session data loss when using AJAX - by El Forum - 10-12-2010, 08:13 AM
Solution to session data loss when using AJAX - by El Forum - 10-12-2010, 09:03 AM
Solution to session data loss when using AJAX - by El Forum - 10-12-2010, 10:01 AM
Solution to session data loss when using AJAX - by El Forum - 10-13-2010, 03:01 AM
Solution to session data loss when using AJAX - by El Forum - 10-13-2010, 03:18 AM
Solution to session data loss when using AJAX - by El Forum - 01-20-2011, 06:58 AM
Solution to session data loss when using AJAX - by El Forum - 05-18-2011, 05:00 PM
Solution to session data loss when using AJAX - by El Forum - 05-25-2011, 12:21 PM
Solution to session data loss when using AJAX - by El Forum - 05-25-2011, 03:33 PM
Solution to session data loss when using AJAX - by El Forum - 05-25-2011, 03:54 PM
Solution to session data loss when using AJAX - by El Forum - 05-25-2011, 07:33 PM
Solution to session data loss when using AJAX - by El Forum - 05-26-2011, 08:43 AM
Solution to session data loss when using AJAX - by El Forum - 07-11-2011, 06:10 AM
Solution to session data loss when using AJAX - by El Forum - 07-11-2011, 07:43 AM
Solution to session data loss when using AJAX - by El Forum - 07-11-2011, 08:56 AM
Solution to session data loss when using AJAX - by El Forum - 07-11-2011, 01:21 PM
Solution to session data loss when using AJAX - by El Forum - 08-20-2012, 12:05 PM
Solution to session data loss when using AJAX - by El Forum - 08-23-2012, 08:50 AM
Solution to session data loss when using AJAX - by El Forum - 08-23-2012, 10:20 AM
Solution to session data loss when using AJAX - by El Forum - 08-23-2012, 01:00 PM
Solution to session data loss when using AJAX - by El Forum - 08-23-2012, 01:04 PM



Theme © iAndrew 2016 - Forum software by © MyBB