Reactor Engineers

[eluser]Basketcasesoftware[/eluser]
[quote author="Phil Sturgeon" date="1297922433"][quote author="Rick Jolly" date="1297921628"]Take note. This is exactly the kind of change wiredesignz is upset about. The loader class doesn't need fixing - it needs to be eliminated. Now Basketcasesoftware is off writing a new library loader like he's just discovered php 4.[/quote]

He was offering to document existing functionality to avoid confusion over a quirk that everyone knows about. I suggested it might be better to stop non arrays being converted to a NULL in the constructor. Nobody is talking about re-writing or removing the Loader class.

CodeIgniter works the way it does, and it's obviously going fairly well because we are here. Sure we could rewrite everything and make it use some great PHP 5 autoloading, rewrite the core and go nuts with namespaces while we're at it, but what exactly is the point of that?

If we remove the Loader class right now, people will kick off a lot more than the few complaining about it still being there. Small incremental changes are the name of the game right now, not a full recode. I think the majority will agree with this approach.[/quote]

Exactly. Truth be told I am trying at a later point for a rewrite just to see if certain PHP 4 to PHP 5 conversion can be better done without breaking existing code, but I'm planning on using code wrappers for that. I have been rewriting the library load method but all I've mostly done is just put in a detailed decision tree and experiment with the usage of the map_array function. I'm also commenting what I'm doing in detail. So far I've had positive reviews from those who've actually messed with my work. It's a small thing, but I'm taking the time and effort to study it closely and do it well. I'll admit I've expanded some functionality slightly though simply by considering the possible input combinations of the function and considering the functions purpose.