Welcome Guest, Not a member yet? Register   Sign In
404 Override Not Working
#15

(06-20-2017, 02:37 AM)reactionstudio Wrote:
Martin7483 Wrote:What you need todo is create your own show_404 method or redirect to your custom Notfound controller instead of calling show_404 and pass along any needed arguments

Is this not what extending the core CI_Exceptions class is achieving? ok it's not a separate function, it's extending the core instead to get the same end result but i don't see how this is a bad solution just because it's not the one you would personally go with?

Please can you explain to me why it's a bad / incorrect solution?

First: I already did
Quote:This way you can keep using the show_404 as is, also within your custom Controller without causing an infinite redirect loop.

If the need should arise to call the show_404() method from within the custom Notfound Controller that would cause an infinite redirect loop. Meaning if he would need to call it he would have to again build something to overcome that issue.

Also any 404 unrelated to the forum he is building, will not be routed to the custom notfound controller

Second: Also already mentioned
You are “fixing something” that is not broken. How is that a correct approach to anything?
Reply


Messages In This Thread
404 Override Not Working - by wolfgang1983 - 06-20-2017, 01:18 AM
RE: 404 Override Not Working - by reactionstudio - 06-20-2017, 01:32 AM
RE: 404 Override Not Working - by wolfgang1983 - 06-20-2017, 01:33 AM
RE: 404 Override Not Working - by reactionstudio - 06-20-2017, 01:49 AM
RE: 404 Override Not Working - by wolfgang1983 - 06-20-2017, 01:59 AM
RE: 404 Override Not Working - by reactionstudio - 06-20-2017, 01:52 AM
RE: 404 Override Not Working - by wolfgang1983 - 06-20-2017, 02:00 AM
RE: 404 Override Not Working - by Martin7483 - 06-20-2017, 02:00 AM
RE: 404 Override Not Working - by wolfgang1983 - 06-20-2017, 02:03 AM
RE: 404 Override Not Working - by reactionstudio - 06-20-2017, 02:05 AM
RE: 404 Override Not Working - by wolfgang1983 - 06-20-2017, 02:12 AM
RE: 404 Override Not Working - by Martin7483 - 06-20-2017, 02:21 AM
RE: 404 Override Not Working - by reactionstudio - 06-20-2017, 02:37 AM
RE: 404 Override Not Working - by Martin7483 - 06-20-2017, 02:10 AM
RE: 404 Override Not Working - by Martin7483 - 06-20-2017, 02:54 AM
RE: 404 Override Not Working - by reactionstudio - 06-20-2017, 03:26 AM
RE: 404 Override Not Working - by Martin7483 - 06-20-2017, 04:23 AM



Theme © iAndrew 2016 - Forum software by © MyBB