Welcome Guest, Not a member yet? Register   Sign In
PR - PHP Standard anomalies
#2

Hey John, Thanks for finding those.

However, that's not a proper pull request. What I meant was you can submit pull requests over at GitHub. That makes it simple for me to look at it and see the tests still pass, everything works, and all I have to do is click "merge". Much more likely to get the code changed that way. We are already so swamped with commitments that anything you can do to make things simpler for us to ensure it's good code, works in the overall context, and is something we think benefits the framework, is more likely to make changes actually happen.
Reply


Messages In This Thread
PR - PHP Standard anomalies - by John_Betong - 09-19-2019, 09:30 AM
RE: PR - PHP Standard anomalies - by kilishan - 09-19-2019, 11:12 AM



Theme © iAndrew 2016 - Forum software by © MyBB