Welcome Guest, Not a member yet? Register   Sign In
Time class big bug
#1

(This post was last modified: 10-29-2022, 03:01 AM by kenjis.)

We found a big bug in Time class.
The class is stated as immutable in the docs, but some methods can alter the object state.

We would like to fix the bug, but it is a breaking change.
If users are using following methods in Time, the result will be changed if the bug is fixed.
add()
modify()
setDate()
setISODate()
setTime()
sub()

Do you agree with fixing Time or not?
If you don't use Time or the methods above, you are not affected if Time is fixed.

See https://github.com/codeigniter4/CodeIgni...ssues/6762 for details.
Reply


Messages In This Thread
Time class big bug - by kenjis - 10-29-2022, 02:57 AM
RE: Time class big bug - by captain-sensible - 10-30-2022, 02:35 AM
RE: Time class big bug - by kenjis - 10-30-2022, 02:51 AM
RE: Time class big bug - by ozornick - 10-30-2022, 07:31 AM
RE: Time class big bug - by davis.lasis - 10-30-2022, 08:17 AM
RE: Time class big bug - by InsiteFX - 10-31-2022, 12:17 AM
RE: Time class big bug - by SubrataJ - 10-31-2022, 07:58 AM
RE: Time class big bug - by kenjis - 11-02-2022, 02:26 PM



Theme © iAndrew 2016 - Forum software by © MyBB