MeNeedz Auth

[eluser]meteor[/eluser]
Thx for reply )
I have another question, basically i'm not taking advantage of DataMapper for my current project, just plain sql as some queries would use too much memory. I think there is no way to return an sql error code( in case valid data has not been saved to the database by register() ). In my opinion, it would be quite easy to fix this. You would only have to add an extra property for the main object to store the last sql error in case such has occured ...

As to checking for false values and filtering ... I think this functionality should be delegated to another function in the worst case ... Register() is monumental at the moment, the fewer conditions you store in it the better in my opinion. One function should be responsible for one thing. it would be even better to assume that data passed to this function is clean already (say, you pass array with input data, which was already cleaned and validated externaly, this way you give developers possibility to choose their tools ... You know, validation is one thing, but you still have to deal with rendering errors.). It has yet another advantage, register() is shorter and easier to test and debug. Finally, I believe that validation has nothing to do with registration,and as such should not be mixed in to Auth class. As I mentioned, register function should just get data and save it to the database, return result of the operation and make sure that eventual sql error is available for developers to retrieve ... Decoupling validation and registration would solve the problem of error messages too. Form_validation class would take care of all the stuff related to checking if input was valid.

Of course these are just my loose thoughts that come into my mind when I look at your code ... You should not feel yourself obliged to adding any further functionality, even thought you are the author of Auth class, You have done a lot already. ))

Thx for your reply

regards