Welcome Guest, Not a member yet? Register   Sign In
Carabiner 1.0: Asset Management Library
#14

[eluser]dannyded[/eluser]
Very good library. But you have some bugs in it.

When you try to pass array to $this->carabiner->css method, array offset error appears.
You need to use for each function inside $this->carabiner->js and $this->carabiner->css to when you pass array. For example:

Code:
if( is_array($dev_file) ){
        
        if( is_array($dev_file[0]) ){
        
            foreach($dev_file as $file){
                
                $this->_asset('js', $file[0], $file[1], $file[2]);
            
            }
            
        }else{
            // you are missing this part
            foreach($dev_file as $file){                
                $this->_asset('js', $file, $prod_file, $combine);
            }
            
        }
        
    }else{
    
        $this->_asset('js', $dev_file, $prod_file, $combine);

    }


One more bug is when you set combine = true false and dev = false.
In that case, js or css file path isn't returned correctly.
Solution (arround line 484), you need to set $f = $f instead $f = $this->cache_uri . $f:
Code:
} elseif(!$this->combine && $this->minify_css) { // we want to minify, but not combine
                    
                    // minify each file, cache it, and serve it up. Oy.
                    foreach($this->css as $ref):
                        
                        if( isset($ref['prod']) ){
                        
                            $f = $this->style_uri . $ref['prod'];
                        
                        } else {
                        
                            $f = filemtime( realpath( $this->style_path . $ref['dev'] ) ) . md5($ref['dev']) . '.css';
                        
                            if( !file_exists($this->cache_path.$f) ){
    
                                $c = $this->_minify( 'css', $ref['dev'] );
                                $this->_cache($f, $c);
                            
                            }
                            // $f = $this->cache_uri . $f;
                            $f = $f;

                        }


Messages In This Thread
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 07:23 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 07:30 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 09:26 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 09:56 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 10:07 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 10:16 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 10:24 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 11:26 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-29-2009, 12:48 AM
Carabiner 1.0: Asset Management Library - by El Forum - 01-29-2009, 04:58 AM
Carabiner 1.0: Asset Management Library - by El Forum - 01-29-2009, 07:23 AM
Carabiner 1.0: Asset Management Library - by El Forum - 01-30-2009, 05:47 AM
Carabiner 1.0: Asset Management Library - by El Forum - 01-30-2009, 03:22 PM
Carabiner 1.0: Asset Management Library - by El Forum - 02-01-2009, 12:35 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-01-2009, 04:28 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-02-2009, 08:44 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-02-2009, 08:54 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-06-2009, 12:07 PM
Carabiner 1.0: Asset Management Library - by El Forum - 02-06-2009, 04:00 PM
Carabiner 1.0: Asset Management Library - by El Forum - 02-07-2009, 01:06 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-09-2009, 01:11 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-11-2009, 09:12 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-13-2009, 02:31 PM
Carabiner 1.0: Asset Management Library - by El Forum - 02-13-2009, 03:05 PM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 07:40 AM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 08:57 AM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 09:20 AM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 09:46 AM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 10:38 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-25-2009, 04:00 PM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2009, 06:39 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2009, 07:46 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-26-2010, 01:00 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-26-2010, 07:58 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2010, 01:54 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2010, 02:04 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2010, 05:33 PM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2010, 08:37 PM
Carabiner 1.0: Asset Management Library - by El Forum - 08-28-2010, 09:53 PM
Carabiner 1.0: Asset Management Library - by El Forum - 09-11-2010, 05:35 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-22-2012, 08:09 AM
Carabiner 1.0: Asset Management Library - by El Forum - 11-09-2012, 07:20 AM



Theme © iAndrew 2016 - Forum software by © MyBB