Welcome Guest, Not a member yet? Register   Sign In
Carabiner 1.0: Asset Management Library
#25

[eluser]meteor[/eluser]
Hi,
Just wanted to say a few words on the carabiner library.
In my opinion, it would be much better if library used config file. CI provides very good means of loading configs at initialization time to libraries. It is good to use it. Writing more than one line of code in __construct for a library and more than one line per method of a class is too much to me. Another thing, writitng configs in a cnstructor function is just asking for troubles, library should have one separated config. Next, files should be loaded per class and method, combination of class and method is unique for each aplication so you can use it to index files you want to load like so
class_method = array('js' => array('files_here'),'css' => array('files_here'));
Next, default set of files should be specified, it means , if no configuration for a given method and class is provided, load default js set, for example nothing, and defualt css file , say with media specified for screen ...
adding extra params per class and method can be specified in the config like so: default_set_of_files +js_file_1 +js_file_2 etc ... removing files default_set_of_files -js_file_1 -js_file_2, this way you do not have to look for ceratin things every time you start new project ...

Next ... Your functions are too elaborate ... I come from ruby world, and my opinion is that, function should do one thing, no data types checking, nothing(a developer is repsonsible for providing correct data ), no extra checks, one function one thing to do. These are not methods for customers but for developers so overhead should be taken into account and simplicity should not be the main criteria ... your function are monstrous, they should not ... libraries should not mix php and html, it is not very professional. Next. no tests are provided with your library, why ? I noticed this is the standard way this community provides libraries. How can you extend code if you are not sure if you just have not broken something else ... no comment.
All in all this library presents not much value to me, there is a lot of code in it but not much is attained with it... It would be much better to exclude certain files from the given class method by not including them instaed of minify them ... Configuration is poorly designed, configuring things for every class in the constructor is asking for troubles, you have to remember what you placed and where , with 20 controllers it is not practical at all, honestly it brings more trouble than benefits.

I think this library is not much better than the assets helper ... Try harder man ... One day it might be a decent piece of code but it still lacks a lot to reach ceratain level of quality


Messages In This Thread
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 07:23 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 07:30 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 09:26 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 09:56 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 10:07 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 10:16 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 10:24 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-28-2009, 11:26 PM
Carabiner 1.0: Asset Management Library - by El Forum - 01-29-2009, 12:48 AM
Carabiner 1.0: Asset Management Library - by El Forum - 01-29-2009, 04:58 AM
Carabiner 1.0: Asset Management Library - by El Forum - 01-29-2009, 07:23 AM
Carabiner 1.0: Asset Management Library - by El Forum - 01-30-2009, 05:47 AM
Carabiner 1.0: Asset Management Library - by El Forum - 01-30-2009, 03:22 PM
Carabiner 1.0: Asset Management Library - by El Forum - 02-01-2009, 12:35 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-01-2009, 04:28 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-02-2009, 08:44 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-02-2009, 08:54 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-06-2009, 12:07 PM
Carabiner 1.0: Asset Management Library - by El Forum - 02-06-2009, 04:00 PM
Carabiner 1.0: Asset Management Library - by El Forum - 02-07-2009, 01:06 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-09-2009, 01:11 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-11-2009, 09:12 AM
Carabiner 1.0: Asset Management Library - by El Forum - 02-13-2009, 02:31 PM
Carabiner 1.0: Asset Management Library - by El Forum - 02-13-2009, 03:05 PM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 07:40 AM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 08:57 AM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 09:20 AM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 09:46 AM
Carabiner 1.0: Asset Management Library - by El Forum - 03-08-2009, 10:38 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-25-2009, 04:00 PM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2009, 06:39 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2009, 07:46 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-26-2010, 01:00 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-26-2010, 07:58 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2010, 01:54 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2010, 02:04 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2010, 05:33 PM
Carabiner 1.0: Asset Management Library - by El Forum - 08-27-2010, 08:37 PM
Carabiner 1.0: Asset Management Library - by El Forum - 08-28-2010, 09:53 PM
Carabiner 1.0: Asset Management Library - by El Forum - 09-11-2010, 05:35 AM
Carabiner 1.0: Asset Management Library - by El Forum - 08-22-2012, 08:09 AM
Carabiner 1.0: Asset Management Library - by El Forum - 11-09-2012, 07:20 AM



Theme © iAndrew 2016 - Forum software by © MyBB