Carabiner 1.0: Asset Management Library

[eluser]meteor[/eluser]
phpunit tests or simpletest tests file at worst if you have one ... this way it will be easier to assess memory usage and general performance of your lib ... haven't looked into structure of this lib at an angle of testing, but i hope it is possible to test it as a stndalone code($CI-> ...).

Do you use anything to test your lib as a whole?

Sorry, I'm mad about tests because it is very difficult to add code or test new functionality without test for all methods and at least half of properties of libraries. Often people write something, release it, and ... well let others rely on code only ... I hate to use anything new without running test suite for the code first ... It is essential to me, it is better to find surprises as quickly as possible ... In this community nobody releases libs with tests, I can understand this as it comes to plugins, but libraries and helpers are standalone pieces of code, even if they are not, it is posible to separate them at testing time ... if you use a new library you do this on your own risk, without provided tests it takes hours to write new tests for bigger libs ...

As to html, i add html in views, as I said libs are for developers not for ordinary people, it is not that difficult to add some html in a view instaed of including it in the lin ... you might add your html as a property, what if someone wants to do something rare with the code ... In my opinion no html, javascript or anything else should be in php lib , i know it is difficult to obtain sometimes ... but this way you avoid situation when, lib has 800 lines and then you come up against a situation when your data is not atomic ...
Next , i think methods should not echo anything ... it is so simple to echo something outside a library that you should leave this to the code contained in a view ... this way you still have open road what to do with results of your methods ... results should be assigned to a property of the main object instaed of being echoed, you are using oop, so take advantage of possibilities it brings ...

Next, I don't like this line
$this->CI->load->helper('file');
this is going to make it more difficult to test your code, you should add this code to your library as a standalone method(s) ... or at least prepare your method for some extra returned external code by giving extra parameter to it.

Agian, when you use oop, why do you use return statement instaed of assign result of a function to a property of the main object ... this way your code will be more compact in places outside your lib, functional programming is good for C or Haskell, php5 brings some better possibilities ... use them ...

Regards