index.php, system_folder variable and multisite installation on windows

[eluser]xadio[/eluser]
Bug in Line 65 of index.php. Affects WINDOWS box users who supply full path using '\\' instead of '/'.

Bug:

Code:

if (strpos($system_folder, '/') === FALSE)

Fix:

Code:

if (strpos($system_folder, DIRECTORY_SEPARATOR) === FALSE)

However, I don't think the function is necessary or the condition should be redefined because all it is searching for is a slash. Consider the following examples.

Code:

$system_folder = 'system'; # OK
$system_folder = 'codeigniter/system'; # Not OK

This function also implies that the index.php is somewhere in the path of the codeigniter system directory. Now for a normal install I don't think this makes a difference, but if another like I wish to place my CodeIgniter system directory in a completely different location than the index.php then it will matter.

It would be nice if it were mentioned that "the index.php needs to be in the CI system path unless a full path is specified" in http://ellislab.com/codeigniter/user-gui...index.html .