Welcome Guest, Not a member yet? Register   Sign In
CodeIgniter 2.1.3 is still using legacy 'var' property declarations in core classes
#1

[eluser]coolfactor[/eluser]
After 3 years of happily using CodeIgniter 1.7.2 as the base for my applications, I'm making the switch to CI 2.1.3. With a minimum requirement of PHP 5, I'm surprised to see that some of the core classes are still using "var" instead of public, protected or private to declare class properties.

Also, with Reactor being community-driven, can changes like this be submitted by the community, or must we wait for these types of changes to be submitted by the Ellis team?
#2

[eluser]CroNiX[/eluser]
Sure, but most of those types of changes have already been made in the 3.0 branch.
You can also make changes and issue a pull request on github.
https://github.com/EllisLab/CodeIgniter
#3

[eluser]coolfactor[/eluser]
Ugh! I got myself into this mess. haha. I have my own framework that sits on top of a stock installation of CodeIgniter and extends over 2 dozen of its libraries, adding and modifying functionality. I've been running stable on version 1.x for several years. I finally decided to finish the migration to 2.x over the holiday period. Now maybe I should wait for 3.x before doing all of this work? Hmmm.
#4

[eluser]CroNiX[/eluser]
There is no release date for CI 3. You might check the [probably incomplete] upgrade procedure in the user guide to see what will be required [so far] for upgrading from latest 2.x to 3.
https://github.com/EllisLab/CodeIgniter/...de_300.rst
#5

[eluser]GrahamDj28[/eluser]
Why are all the major bug fixes only being seen too in CI 3.0? As there is no release date, the fixes should also be fixed in CI 2.x




Theme © iAndrew 2016 - Forum software by © MyBB