Multiple database + pconnect issues

[eluser]Nanodeath[/eluser]
Ah, static variables inside methods! I'd forgotten about that...and it's PHP 4 evidently, which is nice. I think we're getting closer. So...correct me if I'm wrong, but that $selected_db variable you have there exists only once in memory, correct? Even for multiple mysql driver instances... Which means if you have two mysql connections to _different_ servers, their behavior might be affected (adversely), right?

In other words, I think this combination of our solutions is most correct...

Code:

function db_select()

{
    static $selected_db = array();
    if(array_key_exists($this->hostname, $selected_db) && $selected_db[$this->hostname] == $this->database){
        return TRUE;
    }
    $selected_db[$this->hostname] = $this->database;

    return @mysql_select_db($this->database, $this->conn_id);

}

function _execute($sql)

{
    $this->db_select();

    $sql = $this->_prep_query($sql);

    return @mysql_query($sql, $this->conn_id);

}

Also, I think db_select should return true if the correct database is already selected, since it is successful in achieving the post-condition is-connected-to-database.

It's sort of annoying efficiency-wise to call db_select on every sql query, but I don't really see a way around it that's PHP 4 compatible (without sticking the var on the CI instance, which...would be horrible, basically).

I've tested it on 5.2.5 only.