Adding property in all Contrellers: MY_Controller vs BaseController

Thanks, I fixed the code in OP.

In case you're interested there are other ways to get the controller.
Here's one way that's a tiny bit more efficient than calling $this->uri->segment(1)

PHP Code:

$this->controller_url = config_item('base_url') . $this->router->class; 


Thanks, I'm going to look into this one. I stil have not played with the router, I'm a novice.  

Or, you could use the PHP magic constant __CLASS__

PHP Code:

$this->controller_url = config_item('base_url')  . __CLASS__; 


Good point, maybe I could even use

PHP Code:

$this->controller_url = config_item('base_url')  . static::class; 


in case I extend the controller, the late static binding would do the job and I wouldn't have to declare again in the extended class $this->controller_url = config_item('base_url')  . __CLASS__;