Welcome Guest, Not a member yet? Register   Sign In
Change request: Join method
#1

This is not a feature or a bug. Therefore, I could not select the desired section.
The join method of classes CodeIgniter\Database\BaseBuilder and CodeIgniter\Database\SQLSRV\Builder contain the same code except for one line.


PHP Code:
//CodeIgniter\Database\BaseBuilder
$this->QBJoin[] = $type 'JOIN ' $table $cond;


//CodeIgniter\Database\SQLSRV\Builder
$this->QBJoin[] = $type 'JOIN ' $this->getFullName($table) . $cond

I think the following changes could optimize the code.

Add method CodeIgniter\Database\BaseBuilder::getFullyQualifiedTableName() or getFQTN() or FQTN()
PHP Code:
private function getFullyQualifiedTableName(string $table): string
{
    return 
$table;


The CodeIgniter\Database\BaseBuilder::join() method can be changed to
PHP Code:
$this->QBJoin[] = $type 'JOIN ' $this->getFullyQualifiedTableName($table) . $cond

Rename CodeIgniter\Database\DRIVER_NAME\Builder::getFullName() to getFullyQualifiedTableName()
Remove CodeIgniter\Database\SQLSRV\Builder::join()
Reply




Theme © iAndrew 2016 - Forum software by © MyBB