Model::update() is dangerous

The only workaround I see for this is checking if the where part was set before or not. Something like:

PHP Code:

    protected function doUpdate($id = null, $data = null, bool $allowNullId = false): bool
    {
        $escape      = $this->escape;
        $this->escape = [];

        $builder = $this->builder();

        if ($id === null && ! $allowNullId && empty($builder->getCompiledQBWhere())) {
            throw new DatabaseException(
                'Updates are not allowed unless they contain a "where" or "like" clause.'
            );
        }

        if ($id) {
            $builder = $builder->whereIn($this->table . '.' . $this->primaryKey, $id);
        }

        // Must use the set() method to ensure to set the correct escape flag
        foreach ($data as $key => $val) {
            $builder->set($key, $val, $escape[$key] ?? null);
        }

        return $builder->update();
    } 


It would still be a BC break, but the overall functionality would remain. Still, I'm not sure this is the best thing to do.

It seems no problem. It prevents unexpected all record updates.
What's your concern?

ci-phpunit-test | CodeIgniter Testing Guide | CodeIgniter 3 to 4 Upgrade Helper