• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
js_img_removal($match) and valid XHTML

#1
[eluser]pistolPete[/eluser]
Hi,

I just discovered something, but I don't know if it's considered a bug:

I tried to generate valid XHTML 1.0, therefore the <img> tag must be closed (<img >).
In CI 1.6.3, file Input.php line 925 in function _js_img_removal($match) the closing "/" gets removed...

Took me a while to find out it's not tinyMCE's fault...

Please have a look at it!

Thanks,

Pete

#2
[eluser]5n4K3[/eluser]
[quote author="pistolPete" date="1218047430"]Hi,

I just discovered something, but I don't know if it's considered a bug:

I tried to generate valid XHTML 1.0, therefore the <img> tag must be closed (<img >).
In CI 1.6.3, file Input.php line 925 in function _js_img_removal($match) the closing "/" gets removed...

Took me a while to find out it's not tinyMCE's fault...

Please have a look at it!

Thanks,

Pete[/quote]
Yes, there is a problem...but is in line 688 in Input.php file
Code:
$str = preg_replace_callback("#<img\s*([^>]*?)(>|$)#si", array($this, '_js_img_removal'), $str);
change line to:
Code:
$str = preg_replace_callback("#<img\s*([^>]*?)(\/>|$)#si", array($this, '_js_img_removal'), $str);
change the regexp and now have xhtml valid images! :p

pd: i will send a bug ticket :p

Grettings!


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2020 MyBB Group.