MSSQL Driver and _protect_identifiers

[eluser]Jackpod[/eluser]
Hi,

I am using CI v1.6.3 and SQL Server 2005 and Active Record is generating errors.

I modified mssql_driver.php at line 465 and this seems to work.

I changed

Code:

return "\"{$item}\"";

to

Code:

return "[{$item}]";

A) Has anyone else experienced this?
B) Is this the correct fix?
C) Can you please explain why I need to change this and why it is not like this by default?

Thanks for your help!

[eluser]Jackpod[/eluser]
Can someone please lend some expertise here. I want to use this application in a live production environment and am concerned about the MSSQL driver. Can anyone tell me...

A) Has anyone else experienced this?
B) Is this the correct fix?
C) Can you please explain why I need to change this and why it is not like this by default?

Thanks so much!

[eluser]Randy Casburn[/eluser]
Hi Jackpod,

Yes, depending on the contents of $item, your fix is necessary in v1.6.3. Please see bug report here: http://codeigniter.com/bug_tracker/bug/4915/

That was fixed in 1.7.0 with the same fix you've implemented. Here is a link to the relevant forum thread that discusses this bug: http://ellislab.com/forums/viewreply/433381/

Hope this helps,

Randy

[eluser]Jackpod[/eluser]
Yes, it does! Thank you.

[eluser]Randy Casburn[/eluser]
Glad to help. You're very welcome.

Welcome to CI!

Randy

[eluser]dcunited08[/eluser]
I had the same issue with 1.6.3 and, so far, I have had no issues with the default 1.7.0 driver.