[eluser]xwero[/eluser]
I have to agree with you. The main problem i have i that some of the functions of the form helper are depending on the form validation class. I think this is a bad way to go because
- none of other classes are depending on a helper
- the functions that are depending on the form validation class don't generate html.
In the feature request section i started a thread about this 'problem'.
As far as your use of a label function goes i can follow your thoughts about adding the same information on two places but the same goes for the field. You still need to add the field to the label function so you could use language helper.
Code:
lang('username','username') // outputs <label for="form_item_id">language_key</label>
And again we have an helper function that has a functionality that is not expected. The EL developers should add the same lang: prefix to the label function for the visible part. IMO there is only a slight relation between the label and the validation so i don't think the library helper needs a label function
Code:
// form_helper
form_label('lang:username','username');
// form_validation_helper
form_validation_label('username');
Another reason why i think the library feels not finished is the fieldname as array handling. i don't use it a lot myself but i did some testing during the time the library was only in the SVN trunk and i didn't see any changes when the 1.7 release became official.