get_mime_by_extension() triggers warning

[eluser]Arjen van Bochoven[/eluser]
get_mime_by_extension() located in helpers/file_helper.php triggers a warning when the supplied file does not have an extension. The following warning is issued:

Message: array_key_exists() [function.array-key-exists]: The first argument should be either a string or an integer


The reason is that the key is empty if there is no extenson to the file. My proposed fix is to change

Code:

$extension = substr(strrchr($file, '.'), 1);

to

Code:

if ( ! $extension = substr(strrchr($file, '.'), 1))
{
    return FALSE;
}

on line 343 (CI 1.7.2) of helpers/file_helper.php

Arjen

[eluser]Derek Allard[/eluser]
Thanks Arjen. Could I ask you to file a bug report for this? Thanks, and nice find.

[eluser]Arjen van Bochoven[/eluser]
Hi Derek, I've reported the bug:

bug_tracker/bug/8875

Thanks,

Arjen