Welcome Guest, Not a member yet? Register   Sign In
CI 2.0 Router.php 404_override adjustments and improvements
#1

[eluser]Ki[/eluser]
Line of core/Router.php reads:

Code:
if (isset($this->routes['404_override']) AND $this->routes['404_override'] != '')

would it not be better:

Code:
if ( !empty($this->routes['404_override']) )

this will fail if $this->routes['404_override'] is not even set.

Also, router class fails if '/' is not set, therefore setting
Code:
$routes['404_override'] = 'controller';
will not allow 404 redirection to controller/index. It has to be set explicitly
Code:
$routes['404_override'] = 'controller/index';
#2

[eluser]TheCore[/eluser]
Thanks




Theme © iAndrew 2016 - Forum software by © MyBB