Login

04-21-2011, 02:23 PM

[eluser]dadamssg87[/eluser]
is it bad practice to load views within views? Basically trying to figure out where i should put code like this...

Code:
if(isset($this->session->userdata('logged_in'))

{

 $this->load->view('loggedin_view');

}

else

{

 $this->load->view('loginform_view');

}

should i put that snippet in a controller? or should i put it in my header_view? Seems like i would write less code if i stuck it in my header_view file. Any suggestions would be great. thanks

04-21-2011, 02:40 PM

[eluser]jgetner[/eluser]
this sort of code should be in your controller as your calling $this->load->view() witch loads your view file into your controller for rendering.

04-21-2011, 03:41 PM

[eluser]dadamssg87[/eluser]
hmm...i guess it seems wrong to have the beginning and end of div tags in different views.

like

header_view.php

Code:
&lt;html&gt;

&lt;head&gt;&lt;/head>

&lt;body&gt;

<div id="header">

loginform_view.php

Code:
&lt;?php

echo form_open('/login');

?&gt;

<div id='register_form'>

    <center><h4>Login!</h4></center>

    <div id='errors'>    

    &lt;?php echo validation_errors(); ?&gt;

    </div>

    Username

    &lt;input type='text' name='username' value="&lt;?php echo set_value('username'); ?&gt;"&gt;&lt;br><br>

    Password <br>    

    &lt;input type='password' name='password'&gt;&lt;br><br>

    <center>&lt;input type='submit' value='Login!'&gt;&lt;/center>

    &lt;?php

    echo form_close();

    echo "<center><br>".anchor('/join', 'Create an account.', array('id' => 'registerlink'))."</center>";

    ?&gt;

</div>

content_view.php

Code:
</div>&lt;!-- end #header div --&gt;

blah blah blah

whereas if you put the if statement in my last post in the header, you could see the beginning and end div tags in the same view. If that makes any sense...