What is "NON-trivial whitespace commit"?

[eluser]kenjis[/eluser]
https://bitbucket.org/ellislab/codeignit...9fbb803b64

Why has the changeset commited?
It seems to me that previous code is more clean.

I can't understand the necessity.
"It broke the Typography class's string replacements, for instance"
What do you mean?

Would someone explain why?

[eluser]Derek Jones[/eluser]
Hi Kenji,

"Non-trivial" means that the whitespace corrections were not merely cosmetic. Code was changed inside strings, for instance in the example of the Typography class, it broke much of the auto-formatting of text that relied on converting double spaces. The commit also modified binary files in the repository, which disabled them completely. It looked like a project-wide find and replace that was executed without any code review or attention to detail or accuracy.

It will of course be a matter of opinion as to whether or not invisible whitespace affects code legibility (spaces at the end of lines, etc.), and in the code comments even less so, since the code itself is unaffected. In this case, it is a matter of convention for two spaces to follow a period in the English language, so those changes also seemed not only unnecessary, but incorrect.

Make sense?

[eluser]kenjis[/eluser]
Thanks for your explanation, Derek

I got it. It's true white space in Typography class's string was changed.
So it changed output.

And you say two spaces to follow a peirod is English language convention,
so two spaces is correct.

Thanks

[eluser]Derek Jones[/eluser]
No problem, Kenji!