Welcome Guest, Not a member yet? Register   Sign In
User guide errors
#1

[eluser]Seppo[/eluser]
Extra file /user_guide/installation/upgrade_155.html

/user_guide/database/active_record.html
where_in, or_where_in, where_not_in, or_where_not_in, raw_where, raw_or_where
All have wrong "produces" sintaxis.
In $this->db->or_where_in() the example calls $this->db->where_in_or
In $this->db->or_where_not_in() the example calls $this->db->where_in
In $this->db->raw_or_where() the example calls $this->db->raw_where

In $this->db->or_not_like() the "produces" is missing the %s
// WHERE title LIKE '&#xma;tch% OR body NOT LIKE 'match'
should be
// WHERE title LIKE '&#xma;tch% OR body NOT LIKE '&#xma;tch%'

In $this->db->having() the "produces" is escaping the SQL as string
// Produces: HAVING 'user_id = 45'
should be
// Produces: HAVING user_id = 45

and also
// Produces: HAVING title = 'My Title', 'id < 45'
should be
// Produces: HAVING title = 'My Title' and id < 45
#2

[eluser]Derek Allard[/eluser]
Thanks Seppo. Sincerely appreciated, and fixed.
#3

[eluser]Seppo[/eluser]
Cool =)
But there is still an error

The example SQL generated is wrong
// Produces: AND WHERE username IN ('Frank', 'Todd', 'James')
you should remove the AND, before the WHERE.
The same thing happens for all (or_)?where_(not_)?in methods
#4

[eluser]Derek Allard[/eluser]
Yeah, my thinking was to show that multiple where statements are separated with "AND" (vs "or"). But you raise a good point. I'm away from CI now for the rest of the weekend, but I'll revisit this when I'm back. Thanks for your recent work here Seppo... it has not gone unnoticed or unappreciated.
#5

[eluser]Seppo[/eluser]
Thanks Derek.
I've see you lied me and worked a bit more =)
On the new Email helper user guide page the title, h1, and brief description is about the download helper. Also the sample for loading the helper is missing the quotes on "email".
#6

[eluser]Derek Allard[/eluser]
Thanks Seppo. As you can tell, I started with the download helper and changed a bit (obviously not enough). Fixed.

The link in the drop down should be there... it's under "helpers" and called "email helper". Do you not see it?
#7

[eluser]Seppo[/eluser]
Yeah, it was a cache issue... I forced the refresh and it was fixed... then I edited my post =)




Theme © iAndrew 2016 - Forum software by © MyBB