useing / in url

#1
[eluser]Peerie_Pear[/eluser]
Hi all CI users

I have a little problem. Im working on a simple webshop, and need to view my product details and i want to use the article /product id as reference

My url is like this:
http://www.mysite.com/webshop/detail/0/aabb4400

The 0 is used to open a certain menu entry, so not related to this post. The aabb4400 is the product /article id in this example. The url above will work.

Problem comes when i have a product / article id with a / in it, then it says that the requested page can't be found.

For example an url like:
http://www.mysqite.com/webshop/detail/0/LS19HALESB/EDC
will produce error: Not Found
The requested URL /webshop/detail/0/LS19HALESB/EDC was not found on this server.

the / is urlencoded to /
Any idea how to solve this issue?

I'm using the mod rewrite as it stands in the manual, using CI 1.5 atm

#2
[eluser]Michael Wales[/eluser]
Probably not the most elegant option, but fairly simple:

You could concatenate all segments after the second segment into a single variable, delimited by a /. Then search that string for 2 /s in a row and substr() off the last one - loop through this process until there are no double /s.

Psuedo-code (assuming some products have up to 2 slashes):
Code:
// URL: domain.com/webshop/detail/0/LS19HALESB/EDC
function detail($menu, $id_1, $id_2 = '', $id_3 = '', $id_4) {
  // $product_id = LS19HALESB/EDC//
  $product_id = $id_1 . '/' . $id_2 . '/' . $id_3 . '/' . $id_4;
  // Look for double slashes - this could only occur if a product_id
  // does not have any slashes in it
  while (strpos($product_id, '//') !== FALSE) {
    // Doubles will always be at the end, pop-off the last character
    $product_id = substr($product_id, 0, -1);
  }
  // $product_id = LS19HALESB/EDC/
  // Clean up any trailing slashes
  if (substr($product_id, -1) == '/') {
    $product_id = substr($product_id, 0, -1);
  }
  // $product_id = LS19HALESB/EDC
}

#3
[eluser]Peerie_Pear[/eluser]
Thanks,

Looked like a solution at first, but the problem is that the 404 error (The requested URL /webshop/detail/0/LS19HALESB/EDC was not found on this server) is not a CI 404 error, so it looks more like an apache (rewrite) problem. (I will test it without rewrite later today)

If i make a test script, that works with $_GET["productid"] vars it working fine (not in the ci dir, so not rewritten by apache) it accepts / in productid in the url without problems.

What i don't get is that i urlencode a string, and that CI apears to see it as an urldecoded string.

Im using CI 1.5 btw, if that makes any difference...

#4
[eluser]louis w[/eluser]
I would not suggest using a / inside of a string like a product id, it only will cause confusion when passing it around in the url. Can you just do a string replace and change them to dashes or something and then do another replace before you query your db?

#5
[eluser]Peerie_Pear[/eluser]
thats a possibility aswel, but maybe its better to use an unique integer id value to link the product details.

I tought it would be nice to have the manufacturer product id in the url. but since they have "weird" characters in it every now and then, i should think of an other solution.

Can anyone tell me waht CI / apache modrewrtie does with the URL that its not accepting urlencoded strings?

#6
[eluser]Michael Wales[/eluser]
Yeah, I would definitely use your own unique ID and just store the manufacturer ID in the same row with the product's information.

Hell, for SEO purposes it would be even better to make your links like: domain.com/products/gmc-denali-blue-widget

I thin you could do a lot of work on your URLs, to be honest, webshop is a poor name for 'store', detail is unnecessary, I would love to see you get rid of the menu parameter (maybe use a session?), and the ID's could be made much more friendlier to use as a programmer.

#7
[eluser]louis w[/eluser]
An easy way to have seo friendly urls and also an easy look up would be to use:
domain.com/products/1234/cool-product

Where cool-product is the product name, but you really ignore that and use the id before it to look up. The name is just there for google.

#8
[eluser]Peerie_Pear[/eluser]
problem is that some product names have a / in it aswell ;-)

@Michael Wales

You have a few good points there, Ill change my URLs and use more logic controller names. About the ID's ill use an unique int identifier for each product.


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2019 MyBB Group.