• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
improve Query Builder to make more complex queries

#11
(05-13-2019, 02:31 AM)iRedds Wrote:
(05-12-2019, 09:24 PM)kilishan Wrote: Looks like someone has submitted a PR for this that I'll review shortly.

It was my PR, but without query grouping.

I am interested in your opinion on the query grouping that I suggested above.

I like your query grouping idea. Personally, I wouldn't mind seeing more streamlining across the database engine like this, but hand my hands full with everything else going on I didn't want to touch anything like that until the framework got to an official release. And I had enough problems with the db refactoring I did do that I didn't want to touch that whole layer anymore than I had to back then. Smile
Support Development  • Practical CodeIgniter 3  • Vulcan - CLI Tools for CI4
Reply

#12
(05-14-2019, 09:49 AM)kilishan Wrote: I like your query grouping idea. Personally, I wouldn't mind seeing more streamlining across the database engine like this, but hand my hands full with everything else going on I didn't want to touch anything like that until the framework got to an official release. And I had enough problems with the db refactoring I did do that I didn't want to touch that whole layer anymore than I had to back then. Smile

And a few more questions.
What to do with the old version of the query grouping (group_start(), etc.)?
Leave for backward compatibility or remove completely?

For query grouping, create a new PR or update an existing one to avoid merge conflicts?
Reply

#13
(05-16-2019, 05:21 AM)iRedds Wrote: And a few more questions.
What to do with the old version of the query grouping (group_start(), etc.)?
Leave for backward compatibility or remove completely?

For query grouping, create a new PR or update an existing one to avoid merge conflicts?

It's a new feature - so new PR please.

Leave for backward compatibility but mark as deprecated in the docs.
Support Development  • Practical CodeIgniter 3  • Vulcan - CLI Tools for CI4
Reply


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2019 MyBB Group.