• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Redis session regression in 3.1.6

#1
The fix in this PR has caused some weird issues for us: https://github.com/bcit-ci/CodeIgniter/pull/5170

The session library is autoloaded and we're using the Redis session driver. With that patch we do not get the "error trying to free lock" issue we had before, but now we see the error in the attached screenshot occur regularly. All of our end points are calling session_write_close immediately or after the last set_userdata call.

It seems to happen more often in areas where we send frequent concurrent AJAX calls. This is the contents of MY_Session.php. There's only one method and it's simply to follow the session libraries naming convention:

PHP Code:
<?php if ( !defined'BASEPATH' ) ) exit( 'No direct script access allowed' );

class 
MY_Session extends CI_Session {
    public function 
sess_write_close( ) {
        
session_write_close( );
    }
}

?>

If I revert the change in that PR the error in the screenshot disappears. Any idea what's going on?


Attached Files Thumbnail(s)
   
Reply


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2019 MyBB Group.