• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
WYSIWYG HTML Editor and Security

#1
Hello and thank you for taking the time to read this.

Im using a WYSIWYG HTML Editor (CKEditor) to allow the end user to use HTML. This will then be outputted at a later stage via the website. 

  • Is the XSS filter from the security class (https://codeigniter.com/user_guide/libra...urity.html) sufficient enough? 
  • Should I add additional protection such as HTML purifier?
  • Should I use regex or strip tags to filter any unwanted tags?
  • What's the best practice outputting data from WYSIWYG HTML Editor?




Thanks in Advance.
Reply

#2
Good questions join them.
Reply

#3
I am no expert on this and have struggled with this myself. HTML purifier is a must, as it also tidies up a lot of the messy HTML these WYSIWIG editors produce. Also it will strip out unwanted tags and, from my vague recollection, where you whitelist the allowed tags. When I tested the purification I found it to be excellent. I could not catch it out.

Personally, I have stopped using these editors, only because of the mess users make with these things. I now just have a form with, for instance, a title field, a subtitle, a paragraph subtitle, a paragraph content, and the ability to add a paragraph or add an image etc. It is a pain but it is a lot more manageable in the long run and preserves your layout/design. Otherwise you get massive purple titles in comic sans, writing with red backgrounds and green text, and usually tons of unwanted line breaks.

Anyway, if anyone knows of a better way to implement WYSIWYG I would love to hear it too.

However, I do like them and there are scenarios where they make sense. I find them unworkable and not as user friendly as you might imagine.

Paul.
Reply

#4
Thanks for your reply @PaulD - This indeed is a touchy subject and has been for myself for many years on the best outcome. - I think a limitation on tags allowed bundled with XSS is the best possible way to approach this.

I believe this may be the best way:

1) Use HTML purifier
2) Limit the amount of tags your user may use within Use HTML purifier. e.g. headings, strong, paragraph, ul/li
3) Use XSS protection provided by CodeIgniter
4) Do not use strip_tags() unless you plan to strip all tags (https://www.reddit.com/r/PHP/comments/nj...trip_tags/)

If anybody can add to this please let me know.
Reply


Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2019 MyBB Group.